Fix menu interaction & cleanup logic#858
Open
BoyanLu1008 wants to merge 1 commit intowordplaydev:mainfrom
Open
Fix menu interaction & cleanup logic#858BoyanLu1008 wants to merge 1 commit intowordplaydev:mainfrom
BoyanLu1008 wants to merge 1 commit intowordplaydev:mainfrom
Conversation
amyjko
reviewed
Nov 17, 2025
Collaborator
amyjko
left a comment
amyjko
left a comment
There was a problem hiding this comment.
Nice work! This resolves many of the cases and the implementation looks reasonable and robust, following established patterns. Here are a few things I noticed in my initial review before we merge this:
- This doesn't resolve the case in the issue where the cursor is at the end
Phrase('' name: '' *). It should suggest additional named inputs, but it doesn't suggest anything). (If this turns out to be a harder or separate issue, feel free to open a new issue for this specific case). - There are two TypeScript errors. Please run
npm run checkand resolve them. - Remove the edit to
package-lock.json
Collaborator
There was a problem hiding this comment.
Please resolve this conflict. There shouldn't be a change to package-lock.json.
Collaborator
|
@BoyanLu1008, do you intend to finish this pull request? |
Collaborator
|
@BoyanLu1008, can you reply? If you are ghosting, please don't, it harms our ability to make progress on this project. If you cannot finish this, just say so, so someone else can pick up th work. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Issue #811 reports that autocomplete is "flaky" when filling function parameters in Evaluate nodes. Two main problems - optional parameters showing up before required ones in suggestions, and caret jumping to random positions after inserting parameters.
Related issues
Verification
Added filtering logic to prioritize required parameters in autocomplete. When there are unfilled required params, optional ones get filtered out. Did this in three places - Evaluate.getPossibleEvaluations(), Autocomplete.getRelativeFieldEdits(), and Autocomplete.getPossibleNodes().
Also fixed the caret position issue in Assign.ts - now it stays at the insertion point instead of jumping to placeholders unless it's explicitly a completion operation.
Tested on Chrome with basic function calls that have required and optional parameters. Required params show up first, optional ones stay hidden until all required are filled. Caret stays where you're typing.
Haven't fully tested variable-length params or nested Evaluate nodes yet.
Checklist